Default channel for Sequence#1569
Conversation
# Conflicts: # pkg/reconciler/sequence/resources/channel.go
…equence # Conflicts: # pkg/apis/messaging/v1alpha1/sequence_types.go # pkg/apis/messaging/v1alpha1/sequence_validation.go # pkg/apis/messaging/v1alpha1/sequence_validation_test.go # pkg/reconciler/sequence/sequence_test.go # pkg/reconciler/testing/sequence.go
knative-prow-robot
added
the
size/L
|
/cc @vaikas-google |
knative-prow-robot
added
the
area/test-and-release
|
forgot to push, my bad... trying again |
|
/test pull-knative-eventing-unit-tests |
|
The following is the coverage report on pkg/.
|
| } | ||
|
|
||
| if equality.Semantic.DeepEqual(ps.ChannelTemplate, eventingduck.ChannelTemplateSpec{}) { | ||
| if ps.ChannelTemplate == nil { |
There was a problem hiding this comment.
What happens if channelTemplate is set but empty?
There was a problem hiding this comment.
you mean something like:
spec:
channelTemplate: {}It will fail because we validate en the next lines wether it has APIVersion and Kind.
There was a problem hiding this comment.
Ahh, it was below the fold, so I didn't notice it.
| } | ||
|
|
||
| if equality.Semantic.DeepEqual(ps.ChannelTemplate, eventingduck.ChannelTemplateSpec{}) { | ||
| if ps.ChannelTemplate == nil { |
There was a problem hiding this comment.
Ahh, it was below the fold, so I didn't notice it.
knative-prow-robot
added
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Harwayne, nachocano, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Having some weird error: /usr/local/go/pkg/tool/linux_amd64/link: signal: killed github.com/knative/eventing/pkg/provisioners/inmemory/clusterchannelprovisioner.test2019/07/26 17:08:09 $WORK/b345/pkg.a(go.o): error reading symbol: read $WORK/b345/pkg.a: cannot allocate memory /test pull-knative-eventing-unit-tests |
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
6 participants
Helps with #1343
Proposed Changes
Release Note