Skip to content

Channel spec revisions iterations#1572

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
lberk:channel-spec-revisions
Jul 26, 2019
Merged

Channel spec revisions iterations#1572
knative-prow-robot merged 3 commits into
knative:masterfrom
lberk:channel-spec-revisions

Conversation

@lberk
Copy link
Copy Markdown
Member

@lberk lberk commented Jul 26, 2019

Adding some of the feedback from #1420 to the channels spec

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 26, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 26, 2019
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, lberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2019
@knative-prow-robot knative-prow-robot merged commit fe6e678 into knative:master Jul 26, 2019
Kaustubh-pande pushed a commit to Kaustubh-pande/eventing that referenced this pull request Sep 3, 2025
Co-authored-by: serverless-qe <serverless-support@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants