Skip to content

Issue 1672: Added e2e test for new Attributes Filters in Triggers #1689

Merged
knative-prow-robot merged 11 commits into
knative:masterfrom
capri-xiyue:issue_1672
Aug 23, 2019
Merged

Issue 1672: Added e2e test for new Attributes Filters in Triggers #1689
knative-prow-robot merged 11 commits into
knative:masterfrom
capri-xiyue:issue_1672

Conversation

@capri-xiyue
Copy link
Copy Markdown
Contributor

@capri-xiyue capri-xiyue commented Aug 16, 2019 •
edited
Loading

Fixes #1672

Proposed Changes

  • Added e2e test for new attributes filters in triggers in broker_default_tests.go

Release Note

NONE

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 16, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Aug 16, 2019
@capri-xiyue
Copy link
Copy Markdown
Contributor Author

capri-xiyue commented Aug 16, 2019

/assign @nachocano

@capri-xiyue
Copy link
Copy Markdown
Contributor Author

capri-xiyue commented Aug 16, 2019

/assign @Fredy-Z

capri-xiyue
capri-xiyue commented Aug 19, 2019
View reviewed changes
Comment thread test/test_images/sendevents/main.go Outdated
Comment thread test/e2e/broker_default_test.go Outdated
@capri-xiyue capri-xiyue changed the title [WIP]Issue 1672: Added e2e test for new Attributes Filters in Triggers Issue 1672: Added e2e test for new Attributes Filters in Triggers Aug 19, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2019
nachocano
nachocano reviewed Aug 19, 2019
View reviewed changes
Comment thread test/base/resources/cloud_event.go Outdated
nachocano
nachocano reviewed Aug 19, 2019
View reviewed changes
Comment thread test/base/resources/eventing.go Outdated
nachocano
nachocano reviewed Aug 19, 2019
View reviewed changes
Comment thread test/base/resources/eventing.go Outdated
nachocano
nachocano reviewed Aug 19, 2019
View reviewed changes
Comment thread test/e2e/broker_default_test.go Outdated
nachocano
nachocano reviewed Aug 19, 2019
View reviewed changes
Comment thread test/e2e/broker_default_test.go Outdated
nachocano
nachocano reviewed Aug 19, 2019
View reviewed changes
Comment thread test/e2e/broker_default_test.go Outdated
nachocano
nachocano reviewed Aug 19, 2019
View reviewed changes
Comment thread test/e2e/broker_default_test.go Outdated
nachocano
nachocano reviewed Aug 19, 2019
View reviewed changes
Comment thread test/e2e/broker_default_test.go Outdated
nachocano
nachocano reviewed Aug 19, 2019
View reviewed changes
Comment thread test/e2e/broker_default_test.go Outdated
nachocano
nachocano reviewed Aug 19, 2019
View reviewed changes
Comment thread test/test_images/sendevents/main.go Outdated
nachocano
nachocano reviewed Aug 19, 2019
View reviewed changes
Comment thread test/test_images/sendevents/main.go Outdated
nachocano
nachocano reviewed Aug 19, 2019
View reviewed changes
Comment thread test/e2e/broker_default_test.go
@capri-xiyue
Copy link
Copy Markdown
Contributor Author

capri-xiyue commented Aug 21, 2019

/retest

nachocano
nachocano reviewed Aug 21, 2019
View reviewed changes
Comment thread test/common/validation.go Outdated
nachocano
nachocano reviewed Aug 21, 2019
View reviewed changes
Comment thread test/common/validation.go Outdated
nachocano
nachocano reviewed Aug 21, 2019
View reviewed changes
Comment thread test/test_images/sendevents/main.go Outdated
nachocano
nachocano reviewed Aug 21, 2019
View reviewed changes
Comment thread test/test_images/sendevents/main.go Outdated
nachocano
nachocano reviewed Aug 21, 2019
View reviewed changes
Comment thread test/e2e/broker_default_test.go Outdated
nachocano
nachocano reviewed Aug 21, 2019
View reviewed changes
Comment thread test/e2e/broker_default_test.go Outdated
nachocano
nachocano reviewed Aug 21, 2019
View reviewed changes
Comment thread test/e2e/broker_default_test.go Outdated
@nachocano
Copy link
Copy Markdown
Contributor

nachocano commented Aug 21, 2019

@capri-xiyue few cosmetic comments and it's good to go! Thanks for doing this!!!

chizhg
chizhg reviewed Aug 21, 2019
View reviewed changes
Comment thread test/base/resources/kube.go Outdated
@nachocano
Copy link
Copy Markdown
Contributor

nachocano commented Aug 21, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2019
@nachocano
Copy link
Copy Markdown
Contributor

nachocano commented Aug 21, 2019

/assign @Harwayne for approval powers!

Harwayne
Harwayne reviewed Aug 22, 2019
View reviewed changes
Comment thread test/base/resources/eventing.go Outdated
Comment thread test/common/validation.go Outdated
Comment thread test/common/validation.go Outdated
Comment thread test/common/validation.go Outdated
Comment thread test/common/validation.go Outdated
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2019
Harwayne
Harwayne reviewed Aug 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2019
@knative-prow-robot knative-prow-robot merged commit 06e151a into knative:master Aug 23, 2019
aslom pushed a commit to aslom/eventing that referenced this pull request Sep 5, 2019
@capri-xiyue @aslom
Issue 1672: Added e2e test for new Attributes Filters in Triggers (kn…
54fc0f5 
…ative#1689)

* refactor broker_default_test.go to table driven structure

* added end to end test for many triggers with attributes

* added e2e test for trigger filter with extension in broker_default_test.go

* fixed invalid resource name

* fixed e2e tests failure

* added multiple extensions support, changed fuzzy log content check to extact log content check

* edited the code based on code review, changed some format

* changed comment format, changed set with map implementation to k8s set

* use gofmt to change formatting

* changed regex to parse event contents from logs
@nachocano nachocano mentioned this pull request Oct 29, 2019
Merged
pierDipi added a commit to pierDipi/eventing that referenced this pull request Apr 7, 2022
@pierDipi
Remove sugar controller since it was merged (knative#1689)
eee1f40 
There is no separate sugar controller anymore since it was merged
into the main controller, see
https://github.com/openshift/knative-eventing/tree/release-next/openshift/ci-operator/knative-images

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srinivashegde86 srinivashegde86 Awaiting requested review from srinivashegde86

@yt3liu yt3liu Awaiting requested review from yt3liu

3 more reviewers

@Harwayne Harwayne Harwayne left review comments

@nachocano nachocano nachocano left review comments

@chizhg chizhg chizhg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Harwayne Harwayne

@nachocano nachocano

@chizhg chizhg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add E2E test for new Attributes Filters in Triggers

6 participants

@capri-xiyue @nachocano @knative-prow-robot @Harwayne @chizhg @googlebot