Skip to content

Remove tools installation from scripts #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
google-prow-robot merged 1 commit into from
Jul 10, 2018
Merged

Remove tools installation from scripts #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions test/e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,6 @@ echo "- Docker is ${KO_DOCKER_REPO}"

trap teardown EXIT

install_ko
Copy link
Copy Markdown

@jessiezcc jessiezcc Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will we need the same change for other repo?

Copy link
Copy Markdown
Contributor Author

@adrcunha adrcunha Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in the PR for knative/serving, I was going to replicate this to all other repos. All the necessary PRs were already sent for review.


if (( ! USING_EXISTING_CLUSTER )); then
# Start Knative Serving.

Expand All @@ -289,8 +287,6 @@ else
fi


(( IS_PROW )) && gcr_auth

# Clean up anything that might still be around...
teardown_k8s_events_test_resources

Expand Down
31 changes: 0 additions & 31 deletions test/library.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,6 @@ readonly OG_K8S_CLUSTER="${K8S_CLUSTER_OVERRIDE}"
readonly OG_K8S_USER="${K8S_USER_OVERRIDE}"
readonly OG_KO_DOCKER_REPO="${KO_DOCKER_REPO}"

# Returns a UUID
function uuid() {
# uuidgen is not available in kubekins images
cat /proc/sys/kernel/random/uuid
}

# Simple header for logging purposes.
function header() {
echo "================================================="
Expand Down Expand Up @@ -96,31 +90,6 @@ function acquire_cluster_admin_role() {
--user=$1
}

# Authenticates the current user to GCR in the current project.
function gcr_auth() {
echo "Authenticating to GCR"
# kubekins-e2e images lack docker-credential-gcr, install it manually.
# TODO(adrcunha): Remove this step once docker-credential-gcr is available.
gcloud components install docker-credential-gcr
docker-credential-gcr configure-docker
echo "Successfully authenticated"
}

# Installs ko in $OUTPUT_GOBIN
function install_ko() {
GOBIN="${OUTPUT_GOBIN}" go install ./vendor/github.com/google/go-containerregistry/cmd/ko
}

# Runs ko; prefers using the one installed by install_ko().
# Parameters: $1..$n - arguments to ko
function ko() {
if [[ -e "${OUTPUT_GOBIN}/ko" ]]; then
"${OUTPUT_GOBIN}/ko" $@
else
ko $@
fi
}

# Waits until a namespace no longer exists
# Parameters: $1 - namespace.
function wait_until_namespace_does_not_exist() {
Expand Down