Skip to content

Update to use serving style webhook constructor. Use strict webhook.#1695

Merged
knative-prow-robot merged 5 commits into
knative:masterfrom
n3wscott:strict
Aug 21, 2019
Merged

Update to use serving style webhook constructor. Use strict webhook.#1695
knative-prow-robot merged 5 commits into
knative:masterfrom
n3wscott:strict

Conversation

@n3wscott
Copy link
Copy Markdown
Contributor

Proposed Changes

  • Update to serving style webhook starter.
  • Use strict webhook.

Release Note

Strict is enable. Which means random junk in a spec will be rejected by the webhook.

/cc @mattmoor

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 19, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2019
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 19, 2019
Comment thread cmd/webhook/main.go
@mattmoor
Copy link
Copy Markdown
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2019
@knative-prow-robot knative-prow-robot merged commit 91d6549 into knative:master Aug 21, 2019
aslom pushed a commit to aslom/eventing that referenced this pull request Sep 5, 2019
…native#1695)

* use newer shared methods from pkg to start webhook.

* update deps.

* lint.

* fix crashloop.

* adding choice.
matzew added a commit to matzew/eventing that referenced this pull request Apr 13, 2022
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
dsimansk pushed a commit to dsimansk/eventing that referenced this pull request Oct 13, 2025
Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux-kflux-prd-rh02[bot] <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants