Skip to content

Refactoring Broker Filter#1735

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
nachocano:stats_reporter
Aug 23, 2019
Merged

Refactoring Broker Filter#1735
knative-prow-robot merged 3 commits into
knative:masterfrom
nachocano:stats_reporter

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

@nachocano nachocano commented Aug 23, 2019

Helps with #1693

Proposed Changes

  • Creating a filter package within pkg/broker, to match our cmd structure, as well as pkg/broker/ingress.
  • This will make easier to have separate statsReporters for metrics (to be done in a follow up PR)

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 23, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 23, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Aug 23, 2019

/assign @Harwayne

Harwayne
Harwayne reviewed Aug 23, 2019
View reviewed changes
Comment thread pkg/broker/context.go
Comment thread pkg/broker/ingress/ingress_handler.go Outdated
Comment thread pkg/broker/metrics.go Outdated
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2019
Harwayne
Harwayne reviewed Aug 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2019
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Aug 23, 2019

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/broker/context.go 100.0% 0.0% -100.0
pkg/broker/filter/filter_handler.go Do not exist 82.2%
pkg/broker/filter/metrics.go Do not exist 66.7%
pkg/broker/ingress/metrics.go 71.4% 66.7% -4.8
pkg/broker/metrics.go 81.8% 50.0% -31.8
pkg/broker/ttl.go 100.0% 0.0% -100.0

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 23, 2019

@nachocano: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-eventing-go-coverage 08fec6f link /test pull-knative-eventing-go-coverage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot merged commit d56fe22 into knative:master Aug 23, 2019
@nachocano nachocano mentioned this pull request Aug 30, 2019
Closed
75 tasks
aslom pushed a commit to aslom/eventing that referenced this pull request Sep 5, 2019
@nachocano @aslom
Refactoring Broker Filter (knative#1735)
91ef358 
* Refactoring for easier use of statsReporter

* utils alias

* changes after code review
matzew added a commit to matzew/eventing that referenced this pull request May 3, 2022
@matzew
Updates on how simple the release cut now is for midstream eventing (k…
17ff2eb 
…native#1735)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grantr grantr Awaiting requested review from grantr

@n3wscott n3wscott Awaiting requested review from n3wscott

1 more reviewer

@Harwayne Harwayne Harwayne left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Harwayne Harwayne

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nachocano @knative-prow-robot @knative-metrics-robot @Harwayne @googlebot