fixed invalid metric name and added scrape config for inmemory channel#1747
Merged
Conversation
knative-prow-robot
added
the
size/M
Contributor
Author
|
|
Contributor
Author
|
/assign @nachocano |
Contributor
|
Can you update the description of the PR, and also add in the release notes that the sources-controller and the imc-controller are scrapable? |
Contributor
|
/assign @Harwayne |
Harwayne
reviewed
Aug 28, 2019
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: capri-xiyue, Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
75 tasks
aslom
pushed a commit
to aslom/eventing
that referenced
this pull request
Sep 5, 2019
knative#1747) * fixed invalid metric name and added scrape config for inmemory channel * refined formatting and delete auto-generated files * added trailing newline * removed app label and use the original label to scrape
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes
Release Note