Add data plane metrics to CronjobSource by sayanh · Pull Request #1790 · knative/eventing

sayanh · 2019-09-02T16:31:15Z

Proposed Changes

Enable metrics cronjobsource

Release Note

 CronJobSource now reports event counts

knative-prow-robot · 2019-09-02T16:31:30Z

Hi @sayanh. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nachocano · 2019-09-03T16:40:32Z

/hold
until #1784 is merged

coryrc · 2019-09-03T17:40:17Z

/cc @Fredy-Z
/uncc @coryrc

chizhg · 2019-09-03T20:42:07Z

/uncc @Fredy-Z

nachocano · 2019-09-13T20:20:32Z

+	"knative.dev/pkg/source"
 )

+type mockReporter struct{}


can we add the eventCount mocking as in here?

eventing/pkg/adapter/apiserver/adapter_test.go

Line 37 in c2e66d1

eventCount int

to validate that we are calling the method?

nachocano · 2019-09-13T20:24:14Z

 		deploymentLister: deploymentInformer.Lister(),
 		eventTypeLister:  eventTypeInformer.Lister(),
 		env:              *env,
+		context:          ctx,


rename to loggingContext, as with apiserversource?

nachocano · 2019-09-13T20:25:27Z

@sayanh thanks for doing this. I added very minor stuff, and if Adam is OK, we can get this one in.

nachocano · 2019-09-13T20:31:51Z

/hold cancel

nachocano · 2019-09-13T20:36:05Z

/lgtm

@Harwayne for approval

…eventing.yaml Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>

Harwayne

Looks great! Just a few remaining comments.

Harwayne · 2019-09-14T00:15:37Z

 	return cj, err
 }
+
+func (r *Reconciler) UpdateFromLoggingConfigMap(cfg *corev1.ConfigMap) {


Let's add a // TODO determine how to push the updated logging config to existing data plane Pods.

Co-Authored-By: Adam Harwayne <harwayne@google.com>

Harwayne

/lgtm
/approve

knative-prow-robot · 2019-09-16T03:30:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, sayanh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Harwayne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-metrics-robot · 2019-09-16T03:34:49Z

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/adapter/cronjobevents/adapter.go	90.3%	91.4%	1.1
pkg/reconciler/cronjobsource/cronjobsource.go	68.0%	69.2%	1.2

knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2019

knative-prow-robot requested review from coryrc and grantr September 2, 2019 16:31

knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2019

googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 2, 2019

knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Sep 2, 2019

mattmoor-sockpuppet reviewed Sep 3, 2019

View reviewed changes

sayanh force-pushed the enable-metrics-cronjobsource branch from a8fae2e to caff537 Compare September 3, 2019 09:11

mattmoor-sockpuppet reviewed Sep 3, 2019

View reviewed changes

sayanh force-pushed the enable-metrics-cronjobsource branch from caff537 to 5c04c4e Compare September 3, 2019 09:20

mattmoor-sockpuppet reviewed Sep 3, 2019

View reviewed changes

knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2019

nachocano mentioned this pull request Sep 3, 2019

E2E Metrics for Importer/Broker/Trigger model #1693

Closed

75 tasks

knative-prow-robot requested review from chizhg and removed request for coryrc September 3, 2019 17:40

sayanh changed the title ~~Enable metrics cronjobsource~~ Adding data plane metrics to CronjobSource Sep 3, 2019

knative-prow-robot removed the request for review from chizhg September 3, 2019 20:42

sayanh force-pushed the enable-metrics-cronjobsource branch 2 times, most recently from f73d5ac to 6adc33e Compare September 10, 2019 11:55

knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 10, 2019

sayanh marked this pull request as ready for review September 10, 2019 11:55

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2019

mattmoor-sockpuppet reviewed Sep 10, 2019

View reviewed changes

sayanh changed the title ~~Adding data plane metrics to CronjobSource~~ Add data plane metrics to CronjobSource Sep 10, 2019

sayanh force-pushed the enable-metrics-cronjobsource branch from 4745c99 to 52bc290 Compare September 13, 2019 20:10

nachocano reviewed Sep 13, 2019

View reviewed changes

knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2019

knative-prow-robot assigned nachocano Sep 13, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2019

sayanh and others added 6 commits September 14, 2019 00:00

Added dataplane metrics cronjobsource

b5683bb

Update config/monitoring/metrics/prometheus/100-prometheus-scrape-kn-…

17a068e

…eventing.yaml Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>

Rebased and refactored

f51e19b

Changed as per PR comments

1f31661

Added tests to validate metric

638cc31

Renamed var

a7e6524

sayanh force-pushed the enable-metrics-cronjobsource branch from 94e3116 to a7e6524 Compare September 13, 2019 22:04

knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2019

Harwayne reviewed Sep 14, 2019

View reviewed changes

sayanh and others added 3 commits September 14, 2019 11:10

Update pkg/reconciler/cronjobsource/cronjobsource.go

d3ed9ff

Co-Authored-By: Adam Harwayne <harwayne@google.com>

Update pkg/reconciler/cronjobsource/cronjobsource.go

0bf1662

Co-Authored-By: Adam Harwayne <harwayne@google.com>

Added TODO

93c8737

Harwayne reviewed Sep 16, 2019

View reviewed changes

knative-prow-robot assigned Harwayne Sep 16, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2019

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2019

knative-prow-robot merged commit 2cf4d81 into knative:master Sep 16, 2019

sayanh deleted the enable-metrics-cronjobsource branch September 16, 2019 08:22

nachocano mentioned this pull request Oct 29, 2019

Adding nachocano to approvers #2118

Merged

Conversation

sayanh commented Sep 2, 2019

Proposed Changes

Uh oh!

knative-prow-robot commented Sep 2, 2019

Uh oh!

nachocano commented Sep 3, 2019

Uh oh!

coryrc commented Sep 3, 2019

Uh oh!

chizhg commented Sep 3, 2019

Uh oh!

nachocano Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

sayanh Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

nachocano Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

nachocano Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

sayanh Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

nachocano commented Sep 13, 2019

Uh oh!

nachocano commented Sep 13, 2019

Uh oh!

nachocano commented Sep 13, 2019

Uh oh!

Harwayne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Harwayne Sep 14, 2019

Choose a reason for hiding this comment

Uh oh!

Harwayne left a comment

Choose a reason for hiding this comment

Uh oh!

knative-prow-robot commented Sep 16, 2019

Uh oh!

knative-metrics-robot commented Sep 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants