Skip to content

Add v1beta2 Flow CRD alongside existing binding CRDs#18

Closed
eobrain wants to merge 2 commits into
knative:masterfrom
eobrain:justAddedFlowCRD
Closed

Add v1beta2 Flow CRD alongside existing binding CRDs#18
eobrain wants to merge 2 commits into
knative:masterfrom
eobrain:justAddedFlowCRD

Conversation

@eobrain
Copy link
Copy Markdown
Contributor

@eobrain eobrain commented Mar 21, 2018

Fixes Issue # #14

Note, this is a reduced-scope version of #16

Proposed Changes

  • Add v1beta2 Flow CRD
  • no changes to README or any other doc
  • no added non-API files for Flow (client, informer, lister)

@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eobrain
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eobrain eobrain mentioned this pull request Mar 21, 2018
@eobrain
Copy link
Copy Markdown
Contributor Author

eobrain commented Mar 21, 2018

/assign inlined

@eobrain
Copy link
Copy Markdown
Contributor Author

eobrain commented Mar 21, 2018

/assign @inlined

@ultrasaurus
Copy link
Copy Markdown
Contributor

@vaikas-google not sure how this relates to later work in the repo....

@inlined
Copy link
Copy Markdown
Contributor

inlined commented Jul 10, 2018

Let's close this. We still want to address naming this week, but this CL is quite stale & has partially been addressed already.

mgencur pushed a commit to mgencur/eventing that referenced this pull request Jan 9, 2019
Wait longer for the dumpy deployment to go down
nachocano pushed a commit to nachocano/eventing that referenced this pull request Feb 25, 2019
Replace the bad errgroup usage with the runnableServer.
vaikas pushed a commit to vaikas/eventing that referenced this pull request Apr 14, 2021
matzew pushed a commit to matzew/eventing that referenced this pull request Dec 7, 2022
* SRVKE-1353 Multiarch test images

* Remove .github content except for multiarch-build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants