Skip to content

ApiServerSource updates#1872

Merged
knative-prow-robot merged 8 commits into
knative:masterfrom
nachocano:apiserversource
Sep 11, 2019
Merged

ApiServerSource updates#1872
knative-prow-robot merged 8 commits into
knative:masterfrom
nachocano:apiserversource

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

Helps with #1693

Proposed Changes

  • Updates based on pkg changes. Moved statsReporter to a source package, as it is done in the webhook.

Release Note

NONE

@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 11, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 11, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

/assign @Harwayne

Copy link
Copy Markdown
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019
@knative-prow-robot knative-prow-robot merged commit b0ab762 into knative:master Sep 11, 2019
matzew added a commit to matzew/eventing that referenced this pull request Sep 14, 2022
…eam branch (knative#1872)

* upgrade to latest dependencies (knative#6493)

bumping knative.dev/hack e9a8475...d35c718:
  > d35c718 [release-1.7] go run... (# 211)
bumping knative.dev/hack/schema e9a8475...d35c718:
  > d35c718 [release-1.7] go run... (# 211)

Signed-off-by: Knative Automation <automation@knative.team>

Signed-off-by: Knative Automation <automation@knative.team>

* upgrade to latest dependencies (knative#6495)

bumping knative.dev/hack d35c718...8d1e4cc:
  > 8d1e4cc fix go run invocation of github hub cli (# 213)
bumping knative.dev/hack/schema d35c718...8d1e4cc:
  > 8d1e4cc fix go run invocation of github hub cli (# 213)

Signed-off-by: Knative Automation <automation@knative.team>

Signed-off-by: Knative Automation <automation@knative.team>

Signed-off-by: Knative Automation <automation@knative.team>
Co-authored-by: knative-automation <automation@knative.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants