Skip to content

Updating metrics documentation#1891

Merged
knative-prow-robot merged 5 commits into
knative:masterfrom
nachocano:metrics_doc
Sep 16, 2019
Merged

Updating metrics documentation#1891
knative-prow-robot merged 5 commits into
knative:masterfrom
nachocano:metrics_doc

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

Helps with #1693

Proposed Changes

  • Removing unused logging configs.
  • Updating current metrics documentation with stackdriver configuration and updated metric names
  • Should be moved to knative/docs --> See Eventing metrics docs#1792

Release Note

NONE

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 16, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 16, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

/assign @Harwayne

nachocano and others added 3 commits September 16, 2019 11:43
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
@n3wscott
Copy link
Copy Markdown
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2019
@knative-prow-robot knative-prow-robot merged commit 69a7041 into knative:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants