Mark Dependency status as Unknown when the dependency object's generation is not equal#1926
Merged
Conversation
…Metadata.Generation and Status.ObservedGeneration are not equal during the trigger reconcile process
knative-prow-robot
added
the
size/M
Contributor
Author
|
/assign @Harwayne |
matzew
reviewed
Sep 19, 2019
| logging.FromContext(ctx).Error("The ObjectMeta Generation of dependency is not equal to the observedGeneration of status", | ||
| zap.Any("ObjectMeta Generation of dependency", dependency.GetGeneration()), | ||
| zap.Any("ObservedGeneration of status", dependency.Status.ObservedGeneration)) | ||
| t.Status.MarkDependencyUnknown("GenerationNotEqual", "The ObjectMeta Generation of dependency %q is not equal to the ObservedGeneration of status %q", dependency.GetGeneration(), dependency.Status.ObservedGeneration) |
Member
|
/lgtm |
Harwayne
reviewed
Sep 19, 2019
Contributor
Harwayne
left a comment
Harwayne
left a comment
There was a problem hiding this comment.
Just a few small comments.
|
The following is the coverage report on pkg/.
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: capri-xiyue, Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
mgencur
added a commit
to openshift-knative/eventing
that referenced
this pull request
Nov 14, 2022
Exporting too many traces may lead to test suite timeouts and the root cause should be common and visible with fewer event traces. Co-authored-by: Martin Gencur <mgencur@redhat.com>
mgencur
added a commit
to mgencur/eventing
that referenced
this pull request
Nov 16, 2022
Exporting too many traces may lead to test suite timeouts and the root cause should be common and visible with fewer event traces. Co-authored-by: Martin Gencur <mgencur@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1911
Proposed Changes
Release Note