Skip to content

Graphana Dashboards for Broker/Trigger and Source metrics#1966

Merged
knative-prow-robot merged 6 commits into
knative:masterfrom
grac3gao-zz:dashboard
Sep 25, 2019
Merged

Graphana Dashboards for Broker/Trigger and Source metrics#1966
knative-prow-robot merged 6 commits into
knative:masterfrom
grac3gao-zz:dashboard

Conversation

@grac3gao-zz
Copy link
Copy Markdown
Contributor

@grac3gao-zz grac3gao-zz commented Sep 25, 2019 •
edited
Loading

Fixes #1821
Fixes #1822

Proposed Changes

  • A dashboard (Knative Eventing - Broker/Trigger)
  • A dashboard (Knative Eventing - Source)
  • Extend the broker ingress event processing latency bucket from 100ms to 10000ms (when creating processing latency graph, found most event processing latencies are located in buckets between 100ms to 10000ms)

Screen Shot 2019-09-24 at 5 22 32 PM
Screen Shot 2019-09-24 at 5 22 41 PM
Screen Shot 2019-09-24 at 5 21 00 PM

Release Note

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 25, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 25, 2019
@grac3gao-zz
Copy link
Copy Markdown
Contributor Author

grac3gao-zz commented Sep 25, 2019

/assign @nachocano

@nachocano
Copy link
Copy Markdown
Contributor

nachocano commented Sep 25, 2019

This looks great!!! Thanks @grac3gao

I changed my mind, can we do the same as you did for processing latencies buckets, to dispatch latencies bucket? Both in the broker ingress and broker filter handler?

@grac3gao-zz @mattmoor-sockpuppet
Update config/monitoring/metrics/grafana/100-grafana-dash-eventing.yaml
1d8bb53 
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
@nachocano
Copy link
Copy Markdown
Contributor

nachocano commented Sep 25, 2019

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019
@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Sep 25, 2019

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Sep 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grac3gao, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2019
@knative-prow-robot knative-prow-robot merged commit 48c13f5 into knative:master Sep 25, 2019
@nachocano nachocano mentioned this pull request Sep 25, 2019
Closed
75 tasks
@grac3gao-zz grac3gao-zz deleted the dashboard branch October 9, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@grantr grantr Awaiting requested review from grantr

1 more reviewer

@mattmoor-sockpuppet mattmoor-sockpuppet mattmoor-sockpuppet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nachocano nachocano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Metrics: Graphana Dashboards for Source metrics Metrics: Graphana Dashboards for Broker/Trigger

7 participants

@grac3gao-zz @nachocano @n3wscott @knative-prow-robot @mattmoor-sockpuppet @googlebot @grac3gao