Skip to content

Run perf tests continuously for IMC channel #2013

Merged
knative-prow-robot merged 6 commits into
knative:masterfrom
grac3gao-zz:channelIMC
Oct 15, 2019
Merged

Run perf tests continuously for IMC channel #2013
knative-prow-robot merged 6 commits into
knative:masterfrom
grac3gao-zz:channelIMC

Conversation

@grac3gao-zz
Copy link
Copy Markdown
Contributor

@grac3gao-zz grac3gao-zz commented Oct 8, 2019 •
edited by vaikas
Loading

Fixes #1970

Proposed Changes

  • Added continuous perf test for IMC channel
  • For one-time perf test of IMC channel, there is a small bug (apiVersion for subscription is messaging.knative.dev/v1alpha1, not eventing.knative.dev/v1alpha1, which will lead to error for 0 received event), fixed this bug
  • Created a new benchmark for this continuous perf test, benchmark_key: '5683818216292352', benchmark_name: "Development - Channel Latency & Throughput", the dev.config file for this benchmark is stored under test/performance/channel-imc/

Release Note

@grac3gao-zz grac3gao-zz requested a review from grantr October 8, 2019 21:16
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 8, 2019
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 8, 2019
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Oct 8, 2019
@chaodaiG
Copy link
Copy Markdown
Contributor

chaodaiG commented Oct 8, 2019

/uncc

@knative-prow-robot knative-prow-robot removed the request for review from chaodaiG October 8, 2019 22:04
chizhg
chizhg reviewed Oct 8, 2019
View reviewed changes
Comment thread test/performance/channel-imc/continuous/100-channel-imc-setup.yaml Outdated
@grac3gao-zz
Copy link
Copy Markdown
Contributor Author

grac3gao-zz commented Oct 9, 2019

/cc @capri-xiyue

@chizhg
Copy link
Copy Markdown
Contributor

chizhg commented Oct 9, 2019

/lgtm
/assign @grantr

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019
@matzew
Copy link
Copy Markdown
Member

matzew commented Oct 10, 2019

/lgtm

grantr
grantr approved these changes Oct 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grac3gao! This looks good, but needs to be updated with the new flags now that #1979 is approved and merging soon.

Comment thread test/performance/channel-imc/continuous/200-channel-imc.yaml Outdated
Comment thread test/performance/channel-imc/continuous/200-channel-imc.yaml Outdated
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2019
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2019
@grac3gao-zz
Copy link
Copy Markdown
Contributor Author

grac3gao-zz commented Oct 15, 2019

update done

grantr
grantr approved these changes Oct 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Oct 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grac3gao, grantr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grantr
Copy link
Copy Markdown
Contributor

grantr commented Oct 15, 2019

/retest

@knative-prow-robot knative-prow-robot merged commit 03c498a into knative:master Oct 15, 2019
@grac3gao-zz grac3gao-zz deleted the channelIMC branch October 15, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@capri-xiyue capri-xiyue Awaiting requested review from capri-xiyue

2 more reviewers

@chizhg chizhg chizhg left review comments

@grantr grantr grantr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@grantr grantr

@matzew matzew

@chizhg chizhg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run perf tests continuously for IMC channel

8 participants

@grac3gao-zz @chaodaiG @chizhg @matzew @knative-prow-robot @grantr @googlebot @grac3gao