Skip to content

Registry in Source Spec#2084

Merged
knative-prow-robot merged 15 commits into
knative:masterfrom
nachocano:reg_source_spec
Oct 24, 2019
Merged

Registry in Source Spec#2084
knative-prow-robot merged 15 commits into
knative:masterfrom
nachocano:reg_source_spec

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

Fixes #2077

Proposed Changes

  • Adding Source Registry
  • Adding EventType Registry

Release Note

NONE

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 24, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Oct 24, 2019

/assign @n3wscott

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 24, 2019
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
Co-Authored-By: mattmoor-sockpuppet <mattmoor+sockpuppet@google.com>
@nachocano
Copy link
Copy Markdown
Contributor Author

/assign @n3wscott

Comment thread docs/spec/sources.md
Comment thread docs/spec/sources.md Outdated
Comment thread docs/spec/sources.md Outdated
Comment thread docs/spec/sources.md Outdated
@n3wscott
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2019
@knative-prow-robot knative-prow-robot merged commit 1b93292 into knative:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add registry documentation to Source spec

6 participants