Handle subscriber URIs#214
Merged
Merged
Conversation
Flows support a TargetURI as an escape hatch instead of a Target resource. This value is passed through to the Subscription's subscriber. Buses will now accept an http:// or https:// based URI as the subscriber. It is generally recomended to avoid using a URI unless nessesary. A DNS host name is preferred as it will be more compatible with the future event delivery protocol, which will detect/negotiate the underlying transport. Refs #189
google-prow-robot
added
the
size/M
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: scothis, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Aug 6, 2019
e2e-tests-openshift.sh github.com/knative -> knative.dev update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flows support a TargetURI as an escape hatch instead of a Target
resource. This value is passed through to the Subscription's subscriber.
Buses will now accept an http:// or https:// based URI as the
subscriber.
It is generally recomended to avoid using a URI unless nessesary. A DNS
host name is preferred as it will be more compatible with the future
event delivery protocol, which will detect/negotiate the underlying
transport.
Refs #189
Proposed Changes
http://orhttps://URIs/assign @vaikas-google