Add at least one sample point for error throughput#2257
Merged
Conversation
knative-prow-robot
added
size/M
chizhg
force-pushed
the
PerfTestImprovement
branch
from
e883d7f to
bfc351a
Compare
Contributor
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
Looks good overall, just a minor nit
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chizhg, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
If there is no sample point added for error throughput metric, plots in the aggregate chart will be disconnected and unintuitive, examples can be seen in https://mako.dev/benchmark?benchmark_key=4926580618952704&tseconds=604800 (the pink and blue plots)
This PR makes the change to at least add one sample point for error throughput metric, so the plots in aggregate chart will not break in the middle.
Release Note
/cc @slinkydeveloper