correcting JSON to camelCase for Uri...#2400
Closed
matzew wants to merge 1 commit into
Closed
Conversation
knative-prow-robot
added
the
size/XS
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Contributor
|
/hold |
knative-prow-robot
added
the
do-not-merge/hold
Contributor
|
I'm going to close this since it's backwards incompatible change. If I missed something, please reopen and we'll revisit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @vaikas
based on #2373 comment.
I have NOT changed existing
v1alpha1bit that are usingURI, where your PR already moved their counterparts tobeta1...Only doing it on trigger now - I will check same on
eventing-contribfor consistency ...