Replace pod name label in broker stats_reporter with random unique name#2451
Merged
Conversation
knative-prow-robot
added
the
size/M
Contributor
|
/assign |
Contributor
Author
|
/hold |
knative-prow-robot
added
the
do-not-merge/hold
yolocs
changed the title
Contributor
Author
|
/unhold |
knative-prow-robot
removed
the
do-not-merge/hold
mikehelmick
reviewed
Jan 27, 2020
n3wscott
reviewed
Jan 28, 2020
n3wscott
reviewed
Jan 28, 2020
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n3wscott, yolocs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Contributor
Author
|
/test pull-knative-eventing-unit-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2405
Also related to: #2425
Proposed Changes
The pod name was used to only keep the labels unique when working with stackdriver. Replace it with random unique id so that downward API (ksvc doesn't support downward API at the moment) is not needed in the podspec to reference the pod name.
Release Note