Skip to content

Refactor broker to have plugable way to reconcile a service#2468

Closed
yolocs wants to merge 1 commit into
knative:masterfrom
yolocs:f/ksvc-2
Closed

Refactor broker to have plugable way to reconcile a service#2468
yolocs wants to merge 1 commit into
knative:masterfrom
yolocs:f/ksvc-2

Conversation

@yolocs
Copy link
Copy Markdown
Contributor

@yolocs yolocs commented Jan 29, 2020

As multiple people have suggested, this is an attempt to split #2425
The ksvc implementation will be contributed to eventing-contrib as well as the ksvc broker controller.

With the ongoing work for broker class, this change clears the way to enable the ksvc broker controller (to be contributed to eventing-contrib) with other eventing core controllers.

To be clear, this is just a local refactoring.

Release Note


@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 29, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 29, 2020
@yolocs
Copy link
Copy Markdown
Contributor Author

yolocs commented Feb 4, 2020

@vaikas this is slightly related with the broker class work because my plan is to fork the broker controller in eventing contrib.

Comment thread pkg/reconciler/service/kube/kube.go Outdated
Comment thread pkg/reconciler/service/base.go Outdated
Comment thread pkg/reconciler/service/kube/kube.go
@yolocs yolocs requested a review from n3wscott February 6, 2020 19:12
@yolocs
Copy link
Copy Markdown
Contributor Author

yolocs commented Feb 7, 2020

@vaikas @mattmoor slightly related with the ongoing work to split channel broker from core controller

@evankanderson
Copy link
Copy Markdown
Member

/assign @vaikas @n3wscott

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yolocs
To complete the pull request process, please assign n3wscott
You can assign the PR to them by writing /assign @n3wscott in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yolocs
Copy link
Copy Markdown
Contributor Author

yolocs commented Feb 19, 2020

This PR has been updated to keep up with the recent broker reconciler changes. @n3wscott

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/broker_lifecycle.go 95.8% 88.5% -7.4
pkg/reconciler/broker/broker.go 79.4% 75.3% -4.1
pkg/reconciler/broker/resources/ingress.go 0.0% 100.0% 100.0
pkg/reconciler/internal/service/kube/kube.go Do not exist 85.9%

@yolocs
Copy link
Copy Markdown
Contributor Author

yolocs commented Feb 20, 2020

@lionelvillard this is a follow-up for splitting #2425

@yolocs yolocs closed this Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants