Add Broker conformance spec#2598
Conversation
knative-prow-robot
added
the
size/M
knative-prow-robot
added
the
approved
aslom
left a comment
aslom
left a comment
There was a problem hiding this comment.
We assume that the data plane characteristics are shared between Channels and Brokers?
| Other versions MAY be rejected. The usage of CloudEvents version 1.0 is RECOMMENDED. | ||
|
|
||
| The Broker SHOULD NOT perform an upgrade of the produced event's CloudEvents version. It SHOULD support both Binary Content Mode and Structured Content Mode of the HTTP Protocol Binding for CloudEvents. | ||
|
|
There was a problem hiding this comment.
Is batched content mode possible or not for brokers to suport? https://github.com/cloudevents/spec/blob/v0.3/http-transport-binding.md#33-batched-content-mode
| Delivered events must conform to the CloudEvents specification. All CloudEvent attributes set by the producer, including the data and specversion attributes, SHOULD be received at the subscriber identical to how they were received by the Broker. | ||
|
|
||
| The Broker SHOULD support delivering events via Binary Content Mode or Structured Content Mode of the HTTP Protocol Binding for CloudEvents. | ||
|
|
There was a problem hiding this comment.
The same question as above about batched content mode support.
| Events contained in delivery responses SHOULD be published to the Broker ingress and processed as if the event had been produced to the Broker's addressable endpoint. | ||
|
|
||
| The subscriber MAY receive a confirmation that a reply event was accepted by the Broker. If the reply event was not accepted, the initial event SHOULD be redelivered to the subscriber. | ||
|
|
There was a problem hiding this comment.
Support for error handling for delivery? https://github.com/knative/eventing/tree/master/docs/delivery
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 participants
Add the Broker conformance spec to
docs/spec. This is copied from the working document https://docs.google.com/document/d/1zjkaO_Nu6Zt4OmzBEmCMTBPj2JtGCSyYgGG5pVyLlBU.Fixes #2306.
Proposed Changes
Release Note
Not a user-visible change.