add delivery options to sequence v1beta1 (API only)#2608
Merged
knative-prow-robot merged 4 commits intoFeb 20, 2020
Conversation
knative-prow-robot
added
the
size/M
knative-prow-robot
added
the
approved
Contributor
Author
vaikas
reviewed
Feb 20, 2020
knative-prow-robot
added
size/L
vaikas
reviewed
Feb 20, 2020
| // This includes things like retries, DLQ, etc. | ||
| // Needed for Roundtripping v1alpha1 <-> v1beta1. | ||
| // +optional | ||
| Delivery *eventingduckv1alpha1.DeliverySpec `json:"delivery,omitempty"` |
Contributor
There was a problem hiding this comment.
How about we make this v1beta1 right off the bat?
|
The following is the coverage report on the affected files.
|
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2302
Proposed Changes
Release Note