Skip to content

add our types for v1beta1 so we get defaults#2645

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
vaikas:v1beta1-defaults
Feb 25, 2020
Merged

add our types for v1beta1 so we get defaults#2645
knative-prow-robot merged 1 commit into
knative:masterfrom
vaikas:v1beta1-defaults

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented Feb 25, 2020

Proposed Changes

  • add v1beta1 types for eventing, flows, messaging so we get the right defaults (v1beta1, not v1alpha1)

Release Note


Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 25, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 25, 2020
@n3wscott
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@n3wscott
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants