Skip to content

Adding namespace and configmappropagations finalizers for the configmappropagations#2653

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
matzew:rbac_fu
Feb 26, 2020
Merged

Adding namespace and configmappropagations finalizers for the configmappropagations#2653
knative-prow-robot merged 2 commits into
knative:masterfrom
matzew:rbac_fu

Conversation

@matzew
Copy link
Copy Markdown
Member

@matzew matzew commented Feb 26, 2020

Fixes #2642

Proposed Changes

  • adding namespaces/finalizers for ConfigMapPropagation

See the OwnerReference of it:
https://github.com/openshift/knative-eventing/blob/release-next/pkg/reconciler/namespace/resources/configmappropagation.go#L32-L35

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 26, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2020
@matzew
Copy link
Copy Markdown
Member Author

matzew commented Feb 26, 2020

With the first commit I was still getting

{
  "level": "info",
  "ts": "2020-02-26T08:57:40.256Z",
  "logger": "controller.configmappropagation-controller.event-broadcaster",
  "caller": "record/event.go:274",
  "msg": "Event(v1.ObjectReference{Kind:\"ConfigMapPropagation\", Namespace:\"default\", Name:\"eventing\", UID:\"672948a4-29e2-4f4e-8220-a6db65c2791b\", APIVersion:\"configs.internal.knative.dev/v1alpha1\", ResourceVersion:\"90576\", FieldPath:\"\"}): type: 'Warning' reason: 'ConfigMapPropagationPropagateSingleConfigMapFailed' Failed to propagate ConfigMap config-observability: error creating ConfigMap in current namespace: configmaps \"eventing-config-observability\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>",
  "commit": "3982907",
  "knative.dev/controller": "configmappropagation-controller"
}

and no confimaps got propagated to the labeled namespaces,

hence adding

      - "configmappropagations/finalizers"

@matzew matzew changed the title Adding namespace finaliazer for the configmappropagations Adding namespace and configmappropagations finalizers for the configmappropagations Feb 26, 2020
@lionelvillard
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@knative-prow-robot knative-prow-robot merged commit 41c35f0 into knative:master Feb 26, 2020
matzew added a commit to matzew/knative-eventing-operator that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RBAC issue with configmappropagations

4 participants