Remove Legacy Client from Eventing

cmd/controller/main.go

@@ -25,9 +25,6 @@ import (
 	"knative.dev/eventing/pkg/reconciler/apiserversource"
 	"knative.dev/eventing/pkg/reconciler/channel"
 	"knative.dev/eventing/pkg/reconciler/eventtype"
-	"knative.dev/eventing/pkg/reconciler/legacyapiserversource"
-	"knative.dev/eventing/pkg/reconciler/legacycontainersource"
-	"knative.dev/eventing/pkg/reconciler/legacycronjobsource"
 	"knative.dev/eventing/pkg/reconciler/parallel"
 	"knative.dev/eventing/pkg/reconciler/pingsource"
 	"knative.dev/eventing/pkg/reconciler/sequence"
@@ -53,11 +50,5 @@ func main() {
 		// Sources
 		apiserversource.NewController,
 		pingsource.NewController,
-
-		// Legacy Sources
-		// TODO(#2312): Remove this after v0.13.
-		legacyapiserversource.NewController,
-		legacycontainersource.NewController,
-		legacycronjobsource.NewController,
 	)
 }

cmd/webhook/main.go

@@ -24,7 +24,6 @@ import (
 	"k8s.io/apimachinery/pkg/types"
 
 	"knative.dev/eventing/pkg/logconfig"
-	"knative.dev/eventing/pkg/reconciler/legacysinkbinding"
 	"knative.dev/pkg/configmap"
 	"knative.dev/pkg/controller"
 	"knative.dev/pkg/injection"
@@ -50,7 +49,6 @@ import (
 	"knative.dev/eventing/pkg/apis/flows"
 	flowsv1alpha1 "knative.dev/eventing/pkg/apis/flows/v1alpha1"
 	flowsv1beta1 "knative.dev/eventing/pkg/apis/flows/v1beta1"
-	legacysourcesv1alpha1 "knative.dev/eventing/pkg/apis/legacysources/v1alpha1"
 	"knative.dev/eventing/pkg/apis/messaging"
 	channeldefaultconfig "knative.dev/eventing/pkg/apis/messaging/config"
 	messagingv1alpha1 "knative.dev/eventing/pkg/apis/messaging/v1alpha1"
@@ -93,13 +91,6 @@ var ourTypes = map[schema.GroupVersionKind]resourcesemantics.GenericCRD{
 	sourcesv1alpha2.SchemeGroupVersion.WithKind("PingSource"):      &sourcesv1alpha2.PingSource{},
 	sourcesv1alpha2.SchemeGroupVersion.WithKind("SinkBinding"):     &sourcesv1alpha2.SinkBinding{},
 
-	// For group sources.eventing.knative.dev.
-	// TODO(#2312): Remove this after v0.13.
-	legacysourcesv1alpha1.SchemeGroupVersion.WithKind("ApiServerSource"): &legacysourcesv1alpha1.ApiServerSource{},
-	legacysourcesv1alpha1.SchemeGroupVersion.WithKind("ContainerSource"): &legacysourcesv1alpha1.ContainerSource{},
-	legacysourcesv1alpha1.SchemeGroupVersion.WithKind("SinkBinding"):     &legacysourcesv1alpha1.SinkBinding{},
-	legacysourcesv1alpha1.SchemeGroupVersion.WithKind("CronJobSource"):   &legacysourcesv1alpha1.CronJobSource{},
-
 	// For group flows.knative.dev
 	// v1alpha1
 	flowsv1alpha1.SchemeGroupVersion.WithKind("Parallel"): &flowsv1alpha1.Parallel{},
@@ -217,29 +208,6 @@ func NewSinkBindingWebhook(opts ...psbinding.ReconcilerOption) injection.Control
 	}
 }
 
-// TODO(#2312): Remove this after v0.13.
-func NewLegacySinkBindingWebhook(opts ...psbinding.ReconcilerOption) injection.ControllerConstructor {
-	return func(ctx context.Context, cmw configmap.Watcher) *controller.Impl {
-		sbresolver := legacysinkbinding.WithContextFactory(ctx, func(types.NamespacedName) {})
-
-		return psbinding.NewAdmissionController(ctx,
-
-			// Name of the resource webhook.
-			"legacysinkbindings.webhook.sources.knative.dev",
-
-			// The path on which to serve the webhook.
-			"/legacysinkbindings",
-
-			// How to get all the Bindables for configuring the mutating webhook.
-			legacysinkbinding.ListAll,
-
-			// How to setup the context prior to invoking Do/Undo.
-			sbresolver,
-			opts...,
-		)
-	}
-}
-
 func NewConversionController(ctx context.Context, cmw configmap.Watcher) *controller.Impl {
 	// Decorate contexts with the current state of the config.
 	store := defaultconfig.NewStore(logging.FromContext(ctx).Named("config-store"))
@@ -383,7 +351,5 @@ func main() {
 
 		// For each binding we have a controller and a binding webhook.
 		sinkbinding.NewController, NewSinkBindingWebhook(sbSelector),
-		// TODO(#2312): Remove this after v0.13.
-		legacysinkbinding.NewController, NewLegacySinkBindingWebhook(sbSelector),
 	)
 }

config/core/deployments/controller.yaml

@@ -53,9 +53,6 @@ spec:
             value: config-observability
           - name: METRICS_DOMAIN
             value: knative.dev/eventing
-          # Legacy CronJobSource
-          - name: CRONJOB_RA_IMAGE
-            value: knative.dev/eventing/cmd/cronjob_receive_adapter
           # PingSource
           - name: PING_IMAGE
             value: knative.dev/eventing/cmd/ping