Skip to content

Simplify demos#270

Closed
inlined wants to merge 2 commits into
knative:masterfrom
inlined:simplify-demos
Closed

Simplify demos#270
inlined wants to merge 2 commits into
knative:masterfrom
inlined:simplify-demos

Conversation

@inlined
Copy link
Copy Markdown
Contributor

@inlined inlined commented Jul 24, 2018

Simplifies the sample/ directory so that our users' first experience is easier.

Proposed Changes

  1. service accounts and service account role bindings are consolidated into an auth.yaml
  2. routes and configs are consolidated into a function.yaml
  3. only use flows in gcppubsub and k8s events samples (leaving github sample since I know it's currently being edited)
  4. update readme to reflect above changes

inlined added 2 commits July 23, 2018 15:31
@inlined
Update demos:
ea35fbc 
1. service accounts and service account role bindings are consolidated
into an auth.yaml
2. routes and configs are consolidated into a function.yaml
3. only use flows in gcppubsub and k8s events samples
4. update readme to reflect above changes
@inlined
rename flow in k8s_events sample
98286cd
@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jul 24, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inlined

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 24, 2018
@inlined
Copy link
Copy Markdown
Contributor Author

inlined commented Jul 24, 2018

/assign @vaikas-google

@inlined
Copy link
Copy Markdown
Contributor Author

inlined commented Jul 24, 2018 •
edited
Loading

/retest

@evankanderson
Copy link
Copy Markdown
Member

evankanderson commented Jul 24, 2018 via email

@inlined
Copy link
Copy Markdown
Contributor Author

inlined commented Jul 24, 2018

Oh nice. I'll put this on

/hold

until you're done and we can chat about what further simplification would be a good idea.

@google-prow-robot google-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2018
@inlined
Copy link
Copy Markdown
Contributor Author

inlined commented Jul 25, 2018

@evankanderson Do you want anything from this PR or should I just close it?

@inlined inlined closed this Aug 1, 2018
matzew pushed a commit to matzew/eventing that referenced this pull request Sep 10, 2019
@openshift-merge-robot
Merge pull request knative#270 from matzew/SRVKE-130_yaml_patch
6d55f8f 
Adding NetworkPolicy workaround for webhook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@inlined @google-prow-robot @evankanderson @vaikas