Skip to content

Unbreak integration tests #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scothis wants to merge 2 commits into from
Closed

Unbreak integration tests #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da4c2fa
Unbreak integration tests
scothis Aug 1, 2018
c70c559
Add channel and subscription dump on flow failure
scothis Aug 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/controller/util/channel_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ func RemoveChannelCondition(status *v1alpha1.ChannelStatus, condType v1alpha1.Ch
// given all other sub-conditions.
func ConsolidateChannelCondition(status *v1alpha1.ChannelStatus) {
subConditionsTypes := []v1alpha1.ChannelConditionType{
v1alpha1.ChannelProvisioned,
// TODO restore ChannelProvisioned condition with issue #285
// v1alpha1.ChannelProvisioned,
v1alpha1.ChannelRoutable,
v1alpha1.ChannelServiceable,
}
Expand Down
2 changes: 2 additions & 0 deletions test/e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ function wait_until_flow_ready() {
kubectl get -n $NAMESPACE flows $NAME -oyaml
kubectl get -n $NAMESPACE jobs $NAME-start -oyaml
kubectl get -n $NAMESPACE feeds $NAME -oyaml
kubectl get -n $NAMESPACE channels $NAME -oyaml
kubectl get -n $NAMESPACE subscriptions $NAME -oyaml
echo -e "Dumping controller manager logs"
kubectl -n knative-eventing logs `kubectl -n knative-eventing get pods -oname | grep controller-manager` controller-manager
echo -e "Dumping controller logs"
Expand Down