Status conformance tests for channels

[aliok]

Fixes #2992

Proposed Changes

• Conformance tests for Channel status
• Does not include tests for Conformance tests for channel subscriber status requirements #2993 nor Conformance testing for Channel URL #1958

Verification happy case:

go test -v -timeout 30s -tags e2e knative.dev/eventing/test/conformance -run ^TestChannelStatus$ -channels="messaging.knative.dev/v1alpha1:InMemoryChannel,messaging.knative.dev/v1alpha1:Channel,messaging.knative.dev/v1beta1:InMemoryChannel"

Verification unhappy case:
To make the test fail for a non-compliant channel:

• create a CRD like following

cat <<EOS |kubectl apply -f -
---
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  name: foochannels.example.com
spec:
  group: example.com
  versions:
    - name: v1
      served: true
      storage: true
  scope: Namespaced
  names:
    plural: foochannels
    singular: foochannel
    kind: FooChannel
EOS

• comment out the client.WaitForResourceReadyOrFail(channelName, &channel) line as the CR for that CRD won't be Ready never ever
• Run the test:

go test -v -timeout 30s -tags e2e knative.dev/eventing/test/conformance -run ^TestChannelStatus$ -channels="example.com/v1:FooChannel"

The test will fail:

{"FooChannel" "example.com/v1"} does not have status.address

[matzew]

/test pull-knative-eventing-unit-tests

[aliok]

@aslom @matzew mind reviewing?

[aliok]

I will write a separate test for the negative case and send a new PR.
(thanks @matzew for the suggestion)

[matzew]

/lgtm

leaving final review/approval for @aslom

[aslom]

Great work

/lgtm

[matzew]

/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/OWNERS [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aliok]

I will write a separate test for the negative case and send a new PR.

I won't do it.
This test is about conformance of the channels. So, if you have a new channel it should pass these conformance tests. Testing an imaginary channel against the conformance tests didn't sound good on a second thought.
If we really want to "test the test", we might come up with a separate execution of this test for the imaginary channel and see if the test fails.