Skip to content

allow the eventing controller to set Deployment owner ref#3057

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
lionelvillard:mtping-fixrbac
Apr 28, 2020
Merged

allow the eventing controller to set Deployment owner ref#3057
knative-prow-robot merged 1 commit into
knative:masterfrom
lionelvillard:mtping-fixrbac

Conversation

@lionelvillard
Copy link
Copy Markdown
Contributor

Fixes #3056

Proposed Changes

  • add missing RBAC cluster role

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 28, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@lionelvillard
Copy link
Copy Markdown
Contributor Author

/assign @matzew

Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lionelvillard,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lionelvillard
Copy link
Copy Markdown
Contributor Author

/test pull-knative-eventing-integration-tests

@knative-prow-robot knative-prow-robot merged commit 3d64d49 into knative:master Apr 28, 2020
@lionelvillard lionelvillard deleted the mtping-fixrbac branch August 28, 2020 15:43
@lionelvillard lionelvillard restored the mtping-fixrbac branch September 3, 2020 15:41
@lionelvillard lionelvillard deleted the mtping-fixrbac branch September 3, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finalizer issue w/ mt ping source deployment

4 participants