Test ParametersFrom feature#307
Conversation
It's only used in one place, and that usage doesn't save any lines of code.
Adds a test of a feed with a ParametersFrom secret key reference.
google-prow-robot
added
the
size/L
|
The following is the coverage report on pkg/.
|
| return feed | ||
| } | ||
|
|
||
| func getSecretStartInProgressFeed() *feedsv1alpha1.Feed { |
There was a problem hiding this comment.
@dprotaso The builder code from knative/serving#1762 would have been helpful here.
|
/retest |
evankanderson
left a comment
evankanderson
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Generally, I'd discourage touching test code & code under test at the same time, but this seems like a straightforward cleanup.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, grantr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
|
/retest |
|
/test pull-knative-eventing-integration-tests |
* Remove unmarshalJSON method It's only used in one place, and that usage doesn't save any lines of code. * Test the secret retrieval code Adds a test of a feed with a ParametersFrom secret key reference.
5 participants
Adds a test exercising the
ParametersFromsecret key reference. Also removes a superfluous helper method that was only used in one place and didn't make that place more terse or more clear.