Skip to content

Add the label eventing.knative.dev/release to the resources missing it#3245

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
houshengbo:add-label-to-resources
Jun 2, 2020
Merged

Add the label eventing.knative.dev/release to the resources missing it#3245
knative-prow-robot merged 1 commit into
knative:masterfrom
houshengbo:add-label-to-resources

Conversation

@houshengbo
Copy link
Copy Markdown

@houshengbo houshengbo commented Jun 1, 2020

Fixes #

Proposed Changes

  • This PR added the label eventing.knative.dev/release to the resources missing it

Release Note


Docs

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 1, 2020
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 1, 2020
@houshengbo houshengbo force-pushed the add-label-to-resources branch from 6462432 to f4e2b0b Compare June 1, 2020 19:49
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 1, 2020
@houshengbo houshengbo force-pushed the add-label-to-resources branch from f4e2b0b to f005981 Compare June 1, 2020 19:52
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 1, 2020
@houshengbo houshengbo force-pushed the add-label-to-resources branch from f005981 to c3195e9 Compare June 1, 2020 19:56
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 1, 2020
@houshengbo houshengbo force-pushed the add-label-to-resources branch from c3195e9 to f8a9e62 Compare June 1, 2020 20:02
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 1, 2020
Copy link
Copy Markdown
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2020
@lionelvillard
Copy link
Copy Markdown
Contributor

/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, houshengbo, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2020
@lionelvillard
Copy link
Copy Markdown
Contributor

flaky unit test!
/test pull-knative-eventing-unit-tests

@knative-prow-robot knative-prow-robot merged commit 9119a2e into knative:master Jun 2, 2020
@aliok aliok mentioned this pull request Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants