Skip to content

add a job for migrating broker storage versions to v1beta1#3262

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
vaikas:migrate-broker-storage-version
Jun 3, 2020
Merged

add a job for migrating broker storage versions to v1beta1#3262
knative-prow-robot merged 1 commit into
knative:masterfrom
vaikas:migrate-broker-storage-version

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented Jun 3, 2020

Fixes #3261

Proposed Changes

  • Add a Preinstall job that migrates Brokers from v1alpha1 to v1beta1.

Release Note

- 🗑️ Remove feature or internal logic
Eventing v1alpha1 API is removed.
action required: You must run pre-install job prior to upgrading to get Brokers to v1beta1 API.

Docs
knative/docs#2543

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 3, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 3, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 3, 2020
matzew
matzew reviewed Jun 3, 2020
View reviewed changes
Comment thread config/pre-install/v0.16.0/dummy.go

// Package preinstall is a placeholder that allows us to pull in config files
// via go mod vendor.
package preinstall
Copy link
Copy Markdown
Member

@matzew matzew Jun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between "preinstall" and upgrade ?

just wondering, since we have post-install, and upgrade already. and now pre-install ?

Just wondering

Copy link
Copy Markdown
Contributor Author

@vaikas vaikas Jun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think upgrade might have been a poor name. I think it's cleaner to indicate which steps need to happen before upgrade (preinstall) and which have to happen after (postinstall). Anyways, that was my thinking :)

Copy link
Copy Markdown
Contributor Author

@vaikas vaikas Jun 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps preupgrade / postupgrade is better? :) Since you don't need to run those if you're doing a fresh install. Serving called it post install, so went with that last time.

Copy link
Copy Markdown
Member

@matzew matzew Jun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I like

pre-install
post-install

I just did not really like upgrade :-)

@lionelvillard
Copy link
Copy Markdown
Contributor

lionelvillard commented Jun 3, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2020
@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Jun 3, 2020

/test pull-knative-eventing-upgrade-tests

@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Jun 3, 2020

/test pull-knative-eventing-integration-tests

@knative-prow-robot knative-prow-robot merged commit 589e383 into knative:master Jun 3, 2020
@vaikas vaikas deleted the migrate-broker-storage-version branch June 3, 2020 22:09
@nlopezgi nlopezgi mentioned this pull request Aug 20, 2020
Merged
@aliok aliok mentioned this pull request Aug 25, 2020
Closed
@nlopezgi nlopezgi mentioned this pull request Sep 2, 2020
Closed
@vaikas vaikas mentioned this pull request Mar 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew left review comments

@aslom aslom Awaiting requested review from aslom

@nachocano nachocano Awaiting requested review from nachocano

Assignees

@lionelvillard lionelvillard

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a 'Preinstall' storage migrator for Brokers.

5 participants

@vaikas @knative-prow-robot @lionelvillard @matzew @googlebot