Skip to content

Performance image code porting to sdk-go v2#3269

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
slinkydeveloper:performance_port
Jun 4, 2020
Merged

Performance image code porting to sdk-go v2#3269
knative-prow-robot merged 1 commit into
knative:masterfrom
slinkydeveloper:performance_port

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fixes #3105

Proposed Changes

  • Ported performance/infra code to sdk-go v2

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 4, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 4, 2020
@knative-prow-robot knative-prow-robot added area/performance area/test-and-release Test infrastructure, tests or release labels Jun 4, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2020
@devguyio
Copy link
Copy Markdown
Contributor

devguyio commented Jun 4, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2020
@devguyio
Copy link
Copy Markdown
Contributor

devguyio commented Jun 4, 2020

/woof

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@Abd4llA: dog image

Details

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot merged commit 36ed1b3 into knative:master Jun 4, 2020
@slinkydeveloper slinkydeveloper deleted the performance_port branch June 4, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/performance area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port performance/infra to cloudevents/sdk-go v2

4 participants