Skip to content

Port Sequence Test to new test images#3280

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
nlopezgi:issue3267-2
Jun 5, 2020
Merged

Port Sequence Test to new test images#3280
knative-prow-robot merged 2 commits into
knative:masterfrom
nlopezgi:issue3267-2

Conversation

@nlopezgi
Copy link
Copy Markdown
Contributor

@nlopezgi nlopezgi commented Jun 5, 2020 •
edited
Loading

Part of #3267

Proposed Changes

  • Ported SequenceTestHelper to new test images

fyi @slinkydeveloper @n3wscott

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 5, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Jun 5, 2020
@nlopezgi nlopezgi force-pushed the issue3267-2 branch 2 times, most recently from 04319c7 to 8c7df10 Compare June 5, 2020 17:10
@nlopezgi
Copy link
Copy Markdown
Contributor Author

nlopezgi commented Jun 5, 2020

I'm still debugging some issues with this test, please hold off review.
/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2020
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jun 5, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestParallel
test/e2e.TestSequence
test/e2e.TestSequence/InMemoryChannel-messaging.knative.dev/v1alpha1
test/e2e.TestSequence/Channel-messaging.knative.dev/v1alpha1
test/e2e.TestSequence/InMemoryChannel-messaging.knative.dev/v1beta1
test/e2e.TestParallel/InMemoryChannel-messaging.knative.dev/v1alpha1
test/e2e.TestParallel/Channel-messaging.knative.dev/v1alpha1
test/e2e.TestParallel/InMemoryChannel-messaging.knative.dev/v1beta1

@slinkydeveloper slinkydeveloper mentioned this pull request Jun 5, 2020
Closed
17 tasks
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 5, 2020
@nlopezgi
Copy link
Copy Markdown
Contributor Author

nlopezgi commented Jun 5, 2020

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2020
@nlopezgi
Copy link
Copy Markdown
Contributor Author

nlopezgi commented Jun 5, 2020

this is now ready for review

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jun 5, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 5, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlopezgi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2020
@knative-prow-robot knative-prow-robot merged commit 420cc6a into knative:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nlopezgi @knative-test-reporter-robot @vaikas @knative-prow-robot @googlebot