Skip to content

Port Channel event transformation Test to new test images#3286

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
nlopezgi:issue3267-5
Jun 8, 2020
Merged

Port Channel event transformation Test to new test images#3286
knative-prow-robot merged 2 commits into
knative:masterfrom
nlopezgi:issue3267-5

Conversation

@nlopezgi
Copy link
Copy Markdown
Contributor

@nlopezgi nlopezgi commented Jun 5, 2020

Part of #3267

Proposed Changes

  • Port ChannelEventTranformationTestHelper to new test images

fyi @slinkydeveloper @vaikas

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 5, 2020
@knative-prow-robot knative-prow-robot added area/test-and-release Test infrastructure, tests or release size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 5, 2020
@slinkydeveloper slinkydeveloper mentioned this pull request Jun 8, 2020
Closed
17 tasks
slinkydeveloper
slinkydeveloper reviewed Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

Comment thread test/lib/resources/kube.go Outdated
Comment thread test/e2e/helpers/channel_event_tranformation_test_helper.go Outdated
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2020
slinkydeveloper
slinkydeveloper approved these changes Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlopezgi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2020
@knative-prow-robot knative-prow-robot merged commit 20b14e7 into knative:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@yt3liu yt3liu Awaiting requested review from yt3liu

1 more reviewer

@slinkydeveloper slinkydeveloper slinkydeveloper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@slinkydeveloper slinkydeveloper

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nlopezgi @knative-prow-robot @slinkydeveloper @googlebot