Skip to content

Broker test helper porting to new test images#3290

Merged
knative-prow-robot merged 11 commits into
knative:masterfrom
slinkydeveloper:broker_test_helper_porting
Jun 8, 2020
Merged

Broker test helper porting to new test images#3290
knative-prow-robot merged 11 commits into
knative:masterfrom
slinkydeveloper:broker_test_helper_porting

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Jun 8, 2020 •
edited
Loading

Part of #3267

Proposed Changes

  • Now AssertWaitMatchSourceData doesn't require anymore the event recorder name
  • Updated sdk-go to master in order to use new event matchers
  • Converted broker_test_helper.go to new images

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 8, 2020
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Jun 8, 2020
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Jun 8, 2020

cc @nlopezgi

@slinkydeveloper slinkydeveloper mentioned this pull request Jun 8, 2020
Closed
17 tasks
@slinkydeveloper slinkydeveloper force-pushed the broker_test_helper_porting branch from ee84989 to 2c6680f Compare June 8, 2020 10:28
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 8, 2020
@slinkydeveloper slinkydeveloper force-pushed the broker_test_helper_porting branch from 22320e1 to bc9693f Compare June 8, 2020 15:46
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2020
@slinkydeveloper
Small fix in AssertWaitMatchSourceData, now it doesn't require anymor…
d4bc77b 
…e the event recorder name

Temporarily brought in event_matchers.go from sdk-go (replaced EventMatchFunc with EventMatcher)

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Converted broker_test_helper.go to new images
9098655 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
typo
91833c3 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Rebase
bc96783 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Fixed build error
212d229 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Updated to sdk-go master to use the new event matchers
fb5a52c 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Fix
1c1d987 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
LICENSE
d84e08d 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Rebase fix
8161655 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper force-pushed the broker_test_helper_porting branch from 6f685d9 to 8161655 Compare June 8, 2020 15:53
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jun 8, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestDefaultBrokerWithManyTriggers
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_deprecated_triggers
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_triggers
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_triggers_using_v1beta1_trigger
test/e2e.TestDefaultBrokerWithManyTriggers/test_default_broker_with_many_attribute_and_extension_triggers
test/e2e.TestChannelBasedBrokerWithManyTriggers
test/e2e.TestChannelBasedBrokerWithManyTriggers/Channel-messaging.knative.dev/v1beta1
test/e2e.TestChannelBasedBrokerWithManyTriggers/Channel-messaging.knative.dev/v1beta1/test_default_broker_with_many_deprecated_triggers

and 8 more.

@slinkydeveloper
Little fix
2a1e426 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Little fix
ea5d431 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jun 8, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 8, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [slinkydeveloper,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit c34b76d into knative:master Jun 8, 2020
@slinkydeveloper slinkydeveloper deleted the broker_test_helper_porting branch June 8, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@chizhg chizhg Awaiting requested review from chizhg

1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@slinkydeveloper @knative-test-reporter-robot @vaikas @knative-prow-robot @mattmoor @googlebot