Ported broker tests to new images and cleanup#3301
Merged
knative-prow-robot merged 2 commits intoJun 10, 2020
Merged
Conversation
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot
added
the
size/L
knative-prow-robot
added
area/test-and-release
Contributor
Author
mattmoor
reviewed
Jun 10, 2020
Member
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
17 tasks
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slinkydeveloper, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Part of #3267
Proposed Changes
TestBrokerConfig,TestBrokerChannelFlowandTestBrokerDeadLetterSinkwere running the same exact helper with same parameters, so i removed theTestBrokerConfigandTestBrokerDeadLetterSinkTestBrokerWithConfigtoBrokerChannelFlowWithTransformation, removed the duplicatedBrokerChannelFlowTestHelper, ported to new test imagesEventTransformationForTriggerTestHelperto new test imagestest/e2e/helpers/broker_test_helper.gotest/e2e/helpers/trigger_no_broker_test_helper.goto new test images