Skip to content

Ported heartbeats and filterevents to sdk-go v2#3307

Merged
knative-prow-robot merged 4 commits into
knative:masterfrom
slinkydeveloper:porting_last_images
Jun 11, 2020
Merged

Ported heartbeats and filterevents to sdk-go v2#3307
knative-prow-robot merged 4 commits into
knative:masterfrom
slinkydeveloper:porting_last_images

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Jun 11, 2020

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Part of #3267

@slinkydeveloper
Ported the last images to sdk-go v2
66b6b02 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 11, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jun 11, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2020
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Jun 11, 2020

cc @nlopezgi

@slinkydeveloper
Removed kncloudevents usage in performance image
344090c 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jun 11, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestContainerSource
test/e2e.TestSinkBindingDeployment
test/e2e.TestSinkBindingCronJob
test/e2e.TestSinkBindingV1Alpha2Deployment
test/e2e.TestSinkBindingV1Alpha2CronJob

@slinkydeveloper
Id defaulter
a0bbf08 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper
Useless version identifier
0c4d8a2 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper mentioned this pull request Jun 11, 2020
Closed
17 tasks
@lionelvillard
Copy link
Copy Markdown
Contributor

lionelvillard commented Jun 11, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2020
@knative-prow-robot knative-prow-robot merged commit 6829842 into knative:master Jun 11, 2020
@slinkydeveloper slinkydeveloper deleted the porting_last_images branch June 11, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steuhs steuhs Awaiting requested review from steuhs

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@lionelvillard lionelvillard

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/performance area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@slinkydeveloper @knative-prow-robot @knative-test-reporter-robot @lionelvillard @googlebot