Port Broker conformance tests to new test images#3326
Merged
knative-prow-robot merged 3 commits intoJun 16, 2020
Merged
Conversation
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot
added
size/L
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
mattmoor
reviewed
Jun 16, 2020
17 tasks
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
changed the title
antoineco
reviewed
Jun 16, 2020
Contributor
antoineco
left a comment
antoineco
left a comment
There was a problem hiding this comment.
Looking good, with one nit to eliminate randomness in tests.
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Contributor
Author
|
@antoineco that should do it |
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Part of #3267
Proposed Changes
TestBrokerTracingto new test images