Skip to content

Increasing the webhook resources #3328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matzew wants to merge 1 commit into from
Closed

Increasing the webhook resources #3328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions config/core/deployments/webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ spec:
resources:
requests:
# taken from serving.
cpu: 20m
memory: 20Mi
cpu: 100m
memory: 100Mi
Copy link
Copy Markdown
Contributor

@antoineco antoineco Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a really high default value for a webhook, and depends a lot on the activity within the cluster. 1000 namespaces is already a high tier, for a very specific production use-case. If every component starts requesting high-tier production values by default, my next local ko apply is gonna be fun. I believe we should stick to a sane, lower-tier expectation by default, just enough to let people deploy Knative and play with it under casual load. 20Mi is enough for this.

I agree with your comment that this should be configurable via the operator

Copy link
Copy Markdown
Member Author

@matzew matzew Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I see that. but IMO 20Mi than is also not really something that works well for a bigger sized prod env.

Copy link
Copy Markdown
Contributor

@vaikas vaikas Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to these values at all, but overall, I think out of the box you should be able to run some workloads, I think we should have a doc that describes what's supported (rough numbers), and then have 'tuning guides'. Rather than anticipate the highest loads, let's document what we support out of the box and help user configure the setup that fits their needs.

limits:
# taken from serving.
cpu: 200m
memory: 200Mi
cpu: 500m
memory: 500Mi

env:
- name: SYSTEM_NAMESPACE
Expand Down