Skip to content

Remove old test images#3329

Merged
knative-prow-robot merged 2 commits into
knative:masterfrom
slinkydeveloper:remove_old_test_facilities
Jun 16, 2020
Merged

Remove old test images#3329
knative-prow-robot merged 2 commits into
knative:masterfrom
slinkydeveloper:remove_old_test_facilities

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

Fixes #3267

Proposed Changes

  • Remove test images eventdetails, event logger, old event sender
  • Remove lib/cloudevents module
  • Removed some orphan code and clean up of lib

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 16, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 16, 2020
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release labels Jun 16, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@antoineco
Copy link
Copy Markdown
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@knative-prow-robot knative-prow-robot merged commit 9e56754 into knative:master Jun 16, 2020
@slinkydeveloper slinkydeveloper deleted the remove_old_test_facilities branch June 16, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port e2e tests to new event sender and event record images

4 participants