Skip to content

Refactor ChannelTestRunner to ComponentTestRunner#3340

Merged
knative-prow-robot merged 3 commits into
knative:masterfrom
devguyio:3116-src-conf-refactor
Jun 18, 2020
Merged

Refactor ChannelTestRunner to ComponentTestRunner#3340
knative-prow-robot merged 3 commits into
knative:masterfrom
devguyio:3116-src-conf-refactor

Conversation

@devguyio
Copy link
Copy Markdown
Contributor

@devguyio devguyio commented Jun 18, 2020

Related: #3122

Proposed Changes

  • Refactor ChannelTestRunner to ComponentTestRunner
  • Extracts test/flags package

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 18, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Jun 18, 2020
matzew
matzew reviewed Jun 18, 2020
View reviewed changes
Comment thread test/conformance/main_test.go Outdated
@@ -26,15 +26,15 @@ import (
"knative.dev/eventing/test/lib"
Copy link
Copy Markdown
Member

@matzew matzew Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about

	testlib "knative.dev/eventing/test/lib"

matzew
matzew reviewed Jun 18, 2020
View reviewed changes
Comment thread test/e2e_flags.go Outdated

metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
testflags "knative.dev/eventing/test/flags"
"knative.dev/eventing/test/lib"
Copy link
Copy Markdown
Member

@matzew matzew Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

	testlib "knative.dev/eventing/test/lib"

matzew
matzew reviewed Jun 18, 2020
View reviewed changes
Comment thread test/conformance/helpers/channel_crd_metadata_test_helper.go Outdated
@@ -25,11 +25,16 @@ import (
"knative.dev/eventing/test/lib"
Copy link
Copy Markdown
Member

@matzew matzew Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

	testlib "knative.dev/eventing/test/lib"

@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 18, 2020

@antoineco please take a look

antoineco
antoineco reviewed Jun 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@antoineco antoineco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the same PR as before but split in two parts, right? Just to know if I need another in depth review or not :)

Comment thread test/conformance/helpers/channel_crd_metadata_test_helper.go Outdated
)

var channelLabels = map[string]string{
"messaging.knative.dev/subscribable": "true",
Copy link
Copy Markdown
Contributor

@antoineco antoineco Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constant is defined so we should is it.

@devguyio
Copy link
Copy Markdown
Contributor Author

devguyio commented Jun 18, 2020

@antoineco yep, we agreed to split the refactoring from the conformance test

@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 18, 2020
mattmoor
mattmoor reviewed Jun 18, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v wire_gen.go)

Comment thread test/conformance/helpers/channel_crd_metadata_test_helper.go Outdated
"k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"knative.dev/eventing/test/lib"
testlib "knative.dev/eventing/test/lib"
Copy link
Copy Markdown
Member

@mattmoor mattmoor Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format Go code:

Suggested change
testlib "knative.dev/eventing/test/lib"

Comment thread test/conformance/helpers/channel_crd_metadata_test_helper.go
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"knative.dev/eventing/test/lib"
testlib "knative.dev/eventing/test/lib"
"knative.dev/eventing/pkg/apis/messaging"
Copy link
Copy Markdown
Member

@mattmoor mattmoor Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format Go code:

Suggested change
"knative.dev/eventing/pkg/apis/messaging"
"knative.dev/eventing/pkg/apis/messaging"
testlib "knative.dev/eventing/test/lib"

Comment thread test/conformance/helpers/channel_crd_metadata_test_helper.go Outdated

var channelLabels = map[string]string{
messaging.SubscribableDuckVersionAnnotation: "true",
"duck.knative.dev/addressable": "true",
Copy link
Copy Markdown
Member

@mattmoor mattmoor Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format Go code:

Suggested change
"duck.knative.dev/addressable": "true",
"duck.knative.dev/addressable": "true",

matzew
matzew approved these changes Jun 18, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

let's see what the bot does, afterwards 🤷‍♂️

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 18, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abd4llA, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@matzew
Copy link
Copy Markdown
Member

matzew commented Jun 18, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@knative-prow-robot knative-prow-robot merged commit d306a0c into knative:master Jun 18, 2020
@nachocano nachocano mentioned this pull request Jun 22, 2020
Merged
This was referenced Jun 22, 2020
Merged
Closed
@aliok aliok mentioned this pull request Jun 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@chizhg chizhg Awaiting requested review from chizhg

@steuhs steuhs Awaiting requested review from steuhs

+2 more reviewers

@mattmoor mattmoor mattmoor left review comments

@antoineco antoineco antoineco left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@devguyio @matzew @knative-prow-robot @mattmoor @antoineco @googlebot