Skip to content

YAML desc for channel template spec#3357

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
aliok:eventing-spec-default-chanel-spec-doc
Jun 22, 2020
Merged

YAML desc for channel template spec#3357
knative-prow-robot merged 1 commit into
knative:masterfrom
aliok:eventing-spec-default-chanel-spec-doc

Conversation

@aliok
Copy link
Copy Markdown
Member

@aliok aliok commented Jun 22, 2020

Proposed Changes

  • Add missing YAML desc for channel template's spec field

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 22, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2020
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2020
@knative-prow-robot knative-prow-robot merged commit b945190 into knative:master Jun 22, 2020
aliok added a commit to aliok/eventing that referenced this pull request Jun 22, 2020
@aliok aliok deleted the eventing-spec-default-chanel-spec-doc branch April 28, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants