Reorg some test runs#3406
Merged
Merged
Conversation
knative-prow-robot
added
size/S
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
vaikas
reviewed
Jun 24, 2020
|
|
||
| TIMEOUT=${TIMEOUT:-30m} | ||
|
|
||
| run_postinstall_V015 || fail_test 'Running postinstall failed' |
Contributor
There was a problem hiding this comment.
Just curious why this is necessary? We're installing the v15 fresh, so there shouldn't need to be a reason for this?
vaikas
reviewed
Jun 24, 2020
|
|
||
| function run_postinstall() { | ||
| ko apply --strict -f ${POST_INSTALL_V015} || return 1 | ||
| function run_preinstall_V016() { |
Contributor
There was a problem hiding this comment.
did you mean to call this on L57 of the test?
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew
force-pushed
the
reorg_upgraade_tests
branch
from
04d33a8 to
93c0718
Compare
Contributor
|
/lgtm |
lberk
pushed a commit
to lberk/eventing
that referenced
this pull request
Jun 26, 2020
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Wessendorf mwessend@redhat.com
Fixes #
Proposed Changes
Release Note
Docs