Skip to content

conversions for imc v1beta1 <->v1#3427

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
nlopezgi:issue3335-3
Jun 26, 2020
Merged

conversions for imc v1beta1 <->v1#3427
knative-prow-robot merged 1 commit into
knative:masterfrom
nlopezgi:issue3335-3

Conversation

@nlopezgi
Copy link
Copy Markdown
Contributor

Part of #3336

Proposed Changes

  • Conversions for in-memory-channel v1beta1<->v1
  • No webhooks in this PR (will be added in upcoming PR)

fyi @vaikas @lionelvillard @aliok

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 26, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 26, 2020
@nlopezgi nlopezgi changed the title conversions for imc v1beta1->v1 conversions for imc v1beta1 <->v1 Jun 26, 2020
@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/messaging/v1beta1/in_memory_channel_conversion.go 100.0% 94.9% -5.1

@n3wscott
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2020
@knative-prow-robot knative-prow-robot merged commit e1e67cf into knative:master Jun 26, 2020
vaikas pushed a commit to vaikas/eventing that referenced this pull request Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants