Skip to content

Added conformance tests for failing status code in channel data plane#3447

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
slinkydeveloper:wrong_status_code
Jun 30, 2020
Merged

Added conformance tests for failing status code in channel data plane#3447
knative-prow-robot merged 1 commit into
knative:masterfrom
slinkydeveloper:wrong_status_code

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Jun 30, 2020

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Fixes #1845

Proposed Changes

  • Added a new test image to send raw http requests (mainly useful to send bad event requests)
  • Added status code checks for 405 and 400 to channel data plane conformance tests
  • Rename TestChannelEventModesAndSpecVersions to TestChannelDataPlaneSuccess

@slinkydeveloper
status code failures asserts in channel conformance data plane
b0da5b1 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 30, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 30, 2020
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

slinkydeveloper commented Jun 30, 2020

/assign @lberk

@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jun 30, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020
@slinkydeveloper slinkydeveloper mentioned this pull request Jun 30, 2020
Closed
@lberk
Copy link
Copy Markdown
Member

lberk commented Jun 30, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jun 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 3fab60c into knative:master Jun 30, 2020
@slinkydeveloper slinkydeveloper deleted the wrong_status_code branch July 1, 2020 06:53
@lberk lberk mentioned this pull request Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steuhs steuhs Awaiting requested review from steuhs

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@lberk lberk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Conformance testing for channel data plane

4 participants

@slinkydeveloper @lberk @knative-prow-robot @googlebot