Add Broker Data Plane Conformance tests for the Ingress and Consumer#3531
Conversation
8a0b895 to
3ef4e95
Compare
mattmoor
left a comment
There was a problem hiding this comment.
Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)
n3wscott
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Want to follow up with the same tests for broker v1? :D
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lberk, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
absolutely! thanks! |
|
/retry |
|
/retest |
|
The following jobs failed:
Automatically retrying due to test flakiness... |
|
Sorry for being late to the party (timezone diff and all :) ). Thanks for doing this, looks great!!! I'll file an issue for documentating how to run these tests for pre-existing brokers without having to look at the code :) |
Adding Data plane conformance tests for ingress and consumer as reported in #2705