Skip to content

Update the job name and label into storage-version-migration-eventing#3542

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
houshengbo:storage-migration-renaming
Jul 9, 2020
Merged

Update the job name and label into storage-version-migration-eventing#3542
knative-prow-robot merged 1 commit into
knative:masterfrom
houshengbo:storage-migration-renaming

Conversation

@houshengbo
Copy link
Copy Markdown

@houshengbo houshengbo commented Jul 8, 2020

Proposed Changes

  • This PR updated the job name and its label into storage-version-migration-eventing. The purpose is to avoid naming conflict with the job in knative serving.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 8, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2020
@houshengbo
Copy link
Copy Markdown
Author

@vaikas

@knative-test-reporter-robot
Copy link
Copy Markdown

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-upgrade-tests pull-knative-eventing-upgrade-tests
pull-knative-eventing-upgrade-tests
2/3

Automatically retrying due to test flakiness...
/test pull-knative-eventing-upgrade-tests

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 8, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@lionelvillard
Copy link
Copy Markdown
Contributor

@houshengbo can you rebase? Ville fixed a bug in the upgrade tests.

/test pull-knative-eventing-upgrade-tests

@knative-prow-robot knative-prow-robot merged commit bf9be1d into knative:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants