Skip to content

Remove channel-broker from tests#3548

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
pierDipi:remove-st-broker-tests
Jul 9, 2020
Merged

Remove channel-broker from tests#3548
knative-prow-robot merged 1 commit into
knative:masterfrom
pierDipi:remove-st-broker-tests

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented Jul 9, 2020

Signed-off-by: Pierangelo Di Pilato pierangelodipilato@gmail.com

Part of #3547

ChannelBasedBroker doesn't exist anymore.

Proposed Changes

  • Remove channel-broker from tests

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 9, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Jul 9, 2020
@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 9, 2020

/lgtm
/approve

Thanks for cleaning my mistake :)

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2020
@knative-prow-robot knative-prow-robot merged commit d2eb028 into knative:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants