Skip to content

Enable HA by default#3564

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
mattmoor:ha-by-default
Jul 13, 2020
Merged

Enable HA by default#3564
knative-prow-robot merged 1 commit intoknative:masterfrom
mattmoor:ha-by-default

Conversation

@mattmoor
Copy link
Copy Markdown
Member

@mattmoor mattmoor commented Jul 10, 2020

  • 🧽 Update or clean up current behavior
High availability is now enabled by default on control-plane components; it can be disabled with --disable-ha for now.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 10, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 10, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
mattmoor
mattmoor commented Jul 10, 2020
View reviewed changes
Comment thread pkg/adapter/v2/main.go
@mattmoor
Copy link
Copy Markdown
Member Author

mattmoor commented Jul 11, 2020

/retest

@knative-test-reporter-robot
Copy link
Copy Markdown

knative-test-reporter-robot commented Jul 11, 2020

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestChannelBasedBrokerWithManyTriggers/InMemoryChannel-messaging.knative.dev/v1beta1
test/e2e.TestChannelBasedBrokerWithManyTriggers/InMemoryChannel-messaging.knative.dev/v1beta1/test_default_broker_with_many_attribute_triggers

@mattmoor mattmoor mentioned this pull request Jul 11, 2020
Merged
lionelvillard
lionelvillard reviewed Jul 13, 2020
View reviewed changes
Comment thread pkg/adapter/v2/config.go
vaikas
vaikas reviewed Jul 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vaikas vaikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread config/core/configmaps/leader-election.yaml Outdated
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2020
@mattmoor
Enable HA by default
f90f57b 
```release-note
High availability is now enabled by default on control-plane components; it can be disabled with --disable-ha for now.
```
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2020
@mattmoor mattmoor changed the title [WIP] Enable HA by default Enable HA by default Jul 13, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 13, 2020
@mattmoor mattmoor mentioned this pull request Jul 13, 2020
Closed
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Jul 13, 2020

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/v2/main.go 61.2% 60.4% -0.8
pkg/adapter/v2/main_message.go 56.8% 55.6% -1.3
pkg/leaderelection/context.go 78.8% 65.6% -13.2

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Jul 13, 2020

/lgtm
/approve

/hold
since others had comments in case they have further comments.

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jul 13, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Jul 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor
Copy link
Copy Markdown
Member Author

mattmoor commented Jul 13, 2020 •
edited
Loading

I am going to leave this open until roughly EOD and then try to land it as I think it may affect our ability to import pkg (it does in serving, but IDK about eventing).

It sounded like @lionelvillard was 👍 before his EOD also. I'm happy to follow up if any comments land after this does.

@lionelvillard
Copy link
Copy Markdown
Contributor

lionelvillard commented Jul 13, 2020

/lgtm

Thanks!

@mattmoor
Copy link
Copy Markdown
Member Author

mattmoor commented Jul 13, 2020

/unhold

Going to unhold now so I can watch the retest for issues. 👀

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2020
@knative-prow-robot knative-prow-robot merged commit 5a3dba0 into knative:master Jul 13, 2020
@mattmoor
Copy link
Copy Markdown
Member Author

mattmoor commented Jul 13, 2020

I guess it didn't retest 🤔

@mattmoor mattmoor deleted the ha-by-default branch July 13, 2020 22:54
@jcrossley3 jcrossley3 mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liu-cong liu-cong Awaiting requested review from liu-cong

2 more reviewers

@lionelvillard lionelvillard lionelvillard left review comments

@vaikas vaikas vaikas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@grantr grantr

@lionelvillard lionelvillard

@vaikas vaikas

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mattmoor @knative-test-reporter-robot @knative-metrics-robot @vaikas @knative-prow-robot @lionelvillard @grantr @googlebot